Page sort mode #2778
Draft
Page sort mode #2778
+159
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need to serialize elements while moving a page. Faster responses with less data to transfer
We want to give the user a visual feedback that the page get persisted after dragndrop sorting. Also this prevents users from accidentilly move more than one page at a time.
If an error happens during dragndrop sort, we reload the Sitemap in order to restore the tree before it got moved around. This should prevent errors from piling up.
We only want to persist the changes if the sitemap was actually changed. Preventing double submitting the same change on the previous node and the new node we only persist if the event was triggered on the new node.
In order to make short actions not distracting we wait with the background color to appear and give it a nice transition
In order to prevent accidental moves (that would alter the page url) users now need to enable sortable mode. We hide the tooltip on the page icon (which is the draggable handle) in order to make it easier to see that move cursor for locked pages. Coloring the background light yellow indicates that we now are in a special mode.
|
This pull request has not seen any activiy in a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
In order to prevent accidental moves (that would alter the page url) users now need to enable sortable mode.
We hide the tooltip on the page icon (which is the draggable handle) in order to make it easier to see that move cursor for
locked pages. Also hiding page actions.
Coloring the background light yellow indicates that we now are in a special mode.
Screenshots
Checklist