-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new dialog class to replace the old one #2858
base: main
Are you sure you want to change the base?
Add a new dialog class to replace the old one #2858
Conversation
4f4c5a8
to
04bebcc
Compare
04bebcc
to
7c750f1
Compare
7c750f1
to
84ce8fc
Compare
84ce8fc
to
0ecde21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2858 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 229 229
Lines 6222 6222
=======================================
Hits 5969 5969
Misses 253 253 ☔ View full report in Codecov by Sentry. |
c7e3773
to
9a600f2
Compare
We need a remote form watcher that handles re-rendering of forms with validation errors See alchemy_cms/app/assets/javascripts/alchemy/alchemy.dialog.js.coffee Lines 104 to 119 in cbef269
dialog.validation.errors.not.shown.mp4 |
0c5c326
to
37caa29
Compare
Add a new dialog class with the same signature and the same properties as the old Dialog implementation. The new one is using the shoelace web components and is working with promises to allow the calling method to react to the user input in the dialog.
46fa38f
to
8e4f75f
Compare
Try to extract the logic to render the content of the dialog and the error handing into a separate component.
8e4f75f
to
c4413e7
Compare
Add a new dialog class with the same signature and the same properties as the old Dialog implementation. The new one is using the shoelace web components and is working with promises to allow the calling method to react to the user input in the dialog.
Checklist