Update clap to 4.0 #1124
Closed
Update clap to 4.0 #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
|
CC #986. |
|
@ljedrz how can we reenable the colored outputs for |
|
Relevant info about Clap 4.* coloring - clap-rs/clap#4132 (comment) |
|
Colors seem to have caused some issues and thus were removed for now. I've tried applying them using different |
|
Do we know if |
|
AFAIK not yet; however, during my search I stumbled upon an ANSI color feature, which we might be able to use to have colors sooner. I'll look into it. |
|
I did take a look, and it doesn't seem doable with |
|
I'll close this PR for now and wait for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colored help output is currently not supported, but there are plans to work around it.
In addition, run
cargo updateas a drive-by.