Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a manual SingleFileExporter #100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theduke
Copy link
Contributor

@theduke theduke commented May 1, 2022

Allows manually exporting a set of types to a single file.

Allows manually exporting a set of types to a single file.
@Mattchine
Copy link

I like this. Thank you.
Ps. I think this PR break when enable format feature.

@theduke
Copy link
Contributor Author

theduke commented May 16, 2022

Any feedback on this?

ps: @Mattchine it seems to work fine with format?

@aaronleopold
Copy link

Happy to help wherever needed get this merged, assuming it is within the scope of the project? Single file exporting (e.g. index.ts) is something I personally would really like to see, but understand if it isn't something the maintainer wants 🙂

@joaoantoniocardoso
Copy link

I'm also missing this feature - I hacked my way out to do the same thing in a custom build.rs, but it would be way better to have this feature merged/available.

@escritorio-gustavo
Copy link
Collaborator

Updated tests to expect type instead of `interface´

@escritorio-gustavo
Copy link
Collaborator

@NyxCode I'm not familiar with this part of the codebase, I think you should have a look

@escritorio-gustavo escritorio-gustavo linked an issue Jan 26, 2024 that may be closed by this pull request

/// Finalize the export.
///
/// Returns the generated typescritp code on success, or an error if any
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in "typescript"

Comment on lines +191 to +195
let buffer = if with_codegen_warning {
NOTE.to_string()
} else {
String::new()
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NyxCode should the codegen warning be optional?

@escritorio-gustavo escritorio-gustavo added the enhancement New feature or request label Jan 26, 2024
@escritorio-gustavo escritorio-gustavo dismissed their stale review February 15, 2024 11:47

It was supposed to be a "comment" review, not "approval"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants