Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to read custom nicknames from new thread data. #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcel-valdez
Copy link
Contributor

Fix the custom nickname functionality.

Essentially all I added was the capability to read the custom nickname data from the new thread object structure.

I also made it so that when the "use custom nickname" option is set, your user now says 'Me' instead of your actual first name and last name.

@marcel-valdez
Copy link
Contributor Author

@SamBergeron can you please review? Thanks.

@marcel-valdez
Copy link
Contributor Author

@Alex-Rose you could review as well 👍 just want this in 😄

@SamBergeron
Copy link
Collaborator

Just checked this.
Here's a couple of things though.
You don't actually need to set the nickname to "Me:" for the current user if he has a set nickname, your own nickname should be in the customization subset, this actually make everything easier.
There's also a small issue. This saves the nicknames based on individual IDs so if you have multiple nicknames in different conversations, it'll show that name in all the conversations.
Ex: Jack is name "foo" in a group chat, if you have a 1-on-1 chat with Jack it'll now show up as "foo"

@marcel-valdez
Copy link
Contributor Author

You're right... and it is quite doable, I'll add the required code to show what you suggest. Just need to use a map for the nicknames where the key is the fb_id + thread_id: nickname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants