Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing miscellany #144

Merged
merged 14 commits into from
Sep 25, 2023
Merged

Conversation

sjspielman
Copy link
Member

Stacked on #140

This PR is just a bunch of stuff...!

One semi-related change I made was to remove the ### GitHub Repositories section from the workshop materials page. We end up linking to training modules in a subsequent section, and since they don't ever need to navigate there, I think we can probably deprecate that whole bit. Any disagreement let me know!

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but for one mismatched screenshot, which is probably fine. GitHub was also being annoying and not showing me all of the screenshots on the page, but we got through it.

I also had a little wording/order thought with the sentence you added.

Finally, since the new screenshots include nice little shadow borders around the windows, I wonder if we still need the extra <br> lines in the "Logging in" section of rstudio-login.md. I haven't looked at the rendered pages for this draft, so up to your judgement.

software-setup/rstudio-login.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

software-setup/screenshots/rstudio-session.png Outdated Show resolved Hide resolved
@@ -15,7 +11,8 @@ PDF versions of the slides we present in this workshop can be found in the [slid

In the `training-modules` repository, each individual module is found in a subfolder of the main page, along with folders containing cheat sheets and setup instructions.

In this training workshop, we will be using the following modules:
In this training workshop, we will be using the following modules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence feels funny ending in a period, but now there is a double "below" (I prefer the The Lone Bellow). So a bit more tweaking is probably needed. Maybe leave the colon and move the sentence about the links to after the list?

Suggested change
In this training workshop, we will be using the following modules.
In this training workshop, we will be using the modules listed below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with this - 548a97d

Any feedback lmk!

Base automatically changed from sjspielman/107-docker-renv to template-refresh September 25, 2023 17:49
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjspielman sjspielman merged commit 6841d74 into template-refresh Sep 25, 2023
1 check passed
@sjspielman sjspielman deleted the sjspielman/104-118-135-refresh branch September 25, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants