-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge template refresh #154
Conversation
…directory which only contained screenshots for those files that were deleted here
…workshop.md out of virtual-workshop
…ry simply named workshop
…ns.md has been renamed to workshop-resources.md, so there are no more relative links to the old file name
…main resources markdown
…of the main resources markdown as well as the other single cell resources file we've been using
…e the only rellink to it in HOME to match final location
… rellink in working-with-your-own-data
…ielman/121-completed-notebooks-virtual-setup
…esources pages, fix rellinks
…ng in additional-resources. Fixed typos along the way
… to dictionary, might as well just update those issue templates now which partially addresses #124
…ty. Have to comment that out in SCHEDULE
…d add tada emoji to script
…w and fix other typoes, added to dictionary, and did CCDL -> Data Lab in code-of-conduct to fix spelling errors and partly satifify #92
… run on PR to template-refresh branch
This reverts commit 1d1bea6.
…ecated Delete deprecated contents
…m DESeq2 vignette since that is hard to maintain
… to something written in 2023, same lab group
…ng with its links, to software-setup-instructions.md, since really there are very few installs vs setup info.
…reenshots Update Zoom procedures and clear out screenshots
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
… one occurrence of this
Inventory all the links
I think tagging by year probably makes the most sense here, rather real version numbers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I loaded and tested both versions of the website, clicking around at many but not all links, and things seemed to be fine.
Before merging this, it probably makes sense to tag the previous version: I'll leave it to you exactly how to do the tags, but as I said, I would probably favor dates over semantic versions.
I do like the idea of dates, but I'm not sure about using just a year. What do you think about |
probably should have tagged you @jashapiro ☝️ |
That is fine. Maybe |
Closes #117
Homestretch! This PR merges
template-refresh
intomain
. I am filing this on a Friday, so I certainly do not expect it to be reviewed or merged today, but this does feel good to file!For review, you'll want to explore the site serving under both
"remote"
and"in-person"
configurations.Noting this bit from #117 -
It is now later 🎉 ! I still think versioning is not a terrible idea, since this is a public template. Any thoughts on this from reviewers? We'd want to reflect a major bump, so we could do -
v0.1
(at least0.<something>
)v1.0
(that said, we might want to wait on this one until we can finalize Add additional instructions for external workshops #147)