Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci version #16964

Merged
merged 1 commit into from Mar 2, 2023
Merged

Update ci version #16964

merged 1 commit into from Mar 2, 2023

Conversation

fengshunli
Copy link
Contributor

What changes are proposed in this pull request?

Please outline the changes and how this PR fixes the issue.

#16963

Why are the changes needed?

Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

@fengshunli
Update ci version
b1ed1c5 
Signed-off-by: fengshunli <1171313930@qq.com>
@alluxio-bot
Copy link
Contributor

Thank you for your pull request.
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA).
It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to cla@alluxio.org

@dbw9580 dbw9580 added the area-build Build (maven, tarball) and tests label Feb 28, 2023
@Xenorith
Copy link
Contributor

may i ask what is the motivation or benefit from the newer versions? or perhaps the older versions are becoming deprecated? @fengshunli
there is a saying about "if it's not broken, don't fix it"

also please take notice of the request to sign the CLA. we cannot merge any contributions until the signed agreement is accepted, thanks.

@fengshunli
Copy link
Contributor Author

The v2 version is just a demo version, the 3 version solves some risks, is safer and has more complete functions

@Xenorith
Copy link
Contributor

this seems like the relevant news article regarding v2 -> v3: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

@fuzhengjia fuzhengjia mentioned this pull request Feb 28, 2023
Open
@fengshunli
Copy link
Contributor Author

fengshunli commented Feb 28, 2023 •
edited

You can see that version 3 has solved a lot of dependency compatibility and loopholes see EPICLab/synectic#1030

@fengshunli
Copy link
Contributor Author

CLA has been signed @Xenorith

@Xenorith
Copy link
Contributor

Xenorith commented Mar 2, 2023

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 1bf26fa into Alluxio:master Mar 2, 2023
YangchenYe323 pushed a commit to YangchenYe323/alluxio that referenced this pull request Apr 16, 2023
@fengshunli @YangchenYe323
Update ci version
061b1bf 
### What changes are proposed in this pull request?

Please outline the changes and how this PR fixes the issue.

Alluxio#16963

### Why are the changes needed?

Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
1. change in user-facing APIs
2. addition or removal of property keys
3. webui

pr-link: Alluxio#16964
change-id: cid-8da7ea42471d3b615289397def114ab384440f2f
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 17, 2023
@fengshunli @jiacheliu3
Update ci version
0451af1 
### What changes are proposed in this pull request?

Please outline the changes and how this PR fixes the issue.

Alluxio#16963

### Why are the changes needed?

Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
1. change in user-facing APIs
2. addition or removal of property keys
3. webui

pr-link: Alluxio#16964
change-id: cid-8da7ea42471d3b615289397def114ab384440f2f
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 17, 2023
@fengshunli @jiacheliu3
Update ci version
a50fd14 
### What changes are proposed in this pull request?

Please outline the changes and how this PR fixes the issue.

Alluxio#16963

### Why are the changes needed?

Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
1. change in user-facing APIs
2. addition or removal of property keys
3. webui

pr-link: Alluxio#16964
change-id: cid-8da7ea42471d3b615289397def114ab384440f2f
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 17, 2023
@fengshunli @jiacheliu3
Update ci version
e90679a 
### What changes are proposed in this pull request?

Please outline the changes and how this PR fixes the issue.

Alluxio#16963

### Why are the changes needed?

Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
1. change in user-facing APIs
2. addition or removal of property keys
3. webui

pr-link: Alluxio#16964
change-id: cid-8da7ea42471d3b615289397def114ab384440f2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xenorith Xenorith Xenorith approved these changes

Assignees
No one assigned
Labels
area-build Build (maven, tarball) and tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fengshunli @alluxio-bot @Xenorith @dbw9580 @HelloHorizon