Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset prompt after completion done #426

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hotpxl
Copy link

@hotpxl hotpxl commented Apr 2, 2024

Somehow if I don't call zle reset-prompt, the highlighting turns off when the completion is done (either there's no more choice or when I ctrl-c)

@hotpxl
Copy link
Author

hotpxl commented Apr 4, 2024

Actually, it also works if I call zle redisplay instead of zle .redisplay (which seems like a cleaner solution).
Is there any reason we are calling the original .redisplay function? In my case, I use z-sy-h and it overrides widgets to highlight stuff.

@hotpxl
Copy link
Author

hotpxl commented Apr 9, 2024

@Aloxaf any comment is much appreciated!

@Aloxaf
Copy link
Owner

Aloxaf commented Apr 24, 2024

What is your plugin loading order? Did you make sure fzf-tab was loaded before z-sy-h?

@hotpxl
Copy link
Author

hotpxl commented Apr 24, 2024

yeah, fzf-tab is loaded before z-sy-h

@Aloxaf
Copy link
Owner

Aloxaf commented Apr 25, 2024

what's the output of echo $widgets[fzf-tab-complete]?

@hotpxl
Copy link
Author

hotpxl commented Apr 25, 2024

echo $widgets[fzf-tab-complete]
user:_zsh_autosuggest_bound_1_fzf-tab-complete

it's rebound by https://github.com/zsh-users/zsh-autosuggestions

@Aloxaf
Copy link
Owner

Aloxaf commented Apr 26, 2024

can you remove zsh-autosuggestions and try again?

@hotpxl
Copy link
Author

hotpxl commented Apr 29, 2024

I removed zsh-autosuggestions, the problem persists. And now

echo $widgets[fzf-tab-complete]
user:_zsh_highlight_widget_orig-s0.0000010000-r30869-fzf-tab-complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants