Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ascent_opts["default_dir"] to "image_name" images #1295

Merged
merged 8 commits into from
May 22, 2024
Merged

Add ascent_opts["default_dir"] to "image_name" images #1295

merged 8 commits into from
May 22, 2024

Conversation

nicolemarsaglia
Copy link
Contributor

No description provided.

@nicolemarsaglia nicolemarsaglia mentioned this pull request May 14, 2024
Open
@cyrush cyrush self-requested a review May 17, 2024 15:18
cyrush
cyrush approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nicolemarsaglia nicolemarsaglia merged commit 8135383 into develop May 22, 2024
20 checks passed
@nicolemarsaglia nicolemarsaglia deleted the task/2024_05_default_dir_bug branch May 22, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrush cyrush cyrush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolemarsaglia @cyrush