perf(core): make Compiler, ApplicationRef and `ApplicationInitSta…

…tus` tree-shakable (angular#45102) The `Compiler`, `ApplicationRef` and `ApplicationInitStatus` classes are registered as non-tree-shakable providers in the `ApplicationModule`. This commit converts them to the tree-shakable providers instead. PR Close angular#45102
AndrewKushnir · Mar 1, 2022 · 56e4e26 · 56e4e26
1 parent d309c43
commit 56e4e26
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 44 deletions.
diff --git a/packages/core/src/application_init.ts b/packages/core/src/application_init.ts
@@ -91,7 +91,7 @@ export const APP_INITIALIZER =
  *
  * @publicApi
  */
-@Injectable()
+@Injectable({providedIn: 'root'})
 export class ApplicationInitStatus {
   private resolve = noop;
   private reject = noop;

diff --git a/packages/core/src/application_module.ts b/packages/core/src/application_module.ts
@@ -6,18 +6,13 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {APP_INITIALIZER, ApplicationInitStatus} from './application_init';
 import {ApplicationRef} from './application_ref';
 import {APP_ID_RANDOM_PROVIDER} from './application_tokens';
-import {Injector, StaticProvider} from './di';
+import {StaticProvider} from './di';
 import {Inject, Optional, SkipSelf} from './di/metadata';
-import {ErrorHandler} from './error_handler';
 import {DEFAULT_LOCALE_ID, USD_CURRENCY_CODE} from './i18n/localization';
 import {DEFAULT_CURRENCY_CODE, LOCALE_ID} from './i18n/tokens';
-import {ComponentFactoryResolver} from './linker';
-import {Compiler} from './linker/compiler';
 import {NgModule} from './metadata';
-import {NgZone} from './zone';
 
 declare const $localize: {locale?: string};
 
@@ -56,17 +51,6 @@ export function getGlobalLocale(): string {
  * that is used to configure the root injector for bootstrapping.
  */
 export const APPLICATION_MODULE_PROVIDERS: StaticProvider[] = [
-  {
-    provide: ApplicationRef,
-    useClass: ApplicationRef,
-    deps: [NgZone, Injector, ErrorHandler, ComponentFactoryResolver, ApplicationInitStatus]
-  },
-  {
-    provide: ApplicationInitStatus,
-    useClass: ApplicationInitStatus,
-    deps: [[new Optional(), APP_INITIALIZER]]
-  },
-  {provide: Compiler, useClass: Compiler, deps: []},
   APP_ID_RANDOM_PROVIDER,
   {
     provide: LOCALE_ID,

diff --git a/packages/core/src/application_ref.ts b/packages/core/src/application_ref.ts
@@ -564,7 +564,7 @@ function optionsReducer<T extends Object>(dst: any, objs: T|T[]): T {
  *
  * @publicApi
  */
-@Injectable()
+@Injectable({providedIn: 'root'})
 export class ApplicationRef {
   /** @internal */
   private _bootstrapListeners: ((compRef: ComponentRef<any>) => void)[] = [];

diff --git a/packages/core/src/linker/compiler.ts b/packages/core/src/linker/compiler.ts
@@ -52,7 +52,7 @@ export class ModuleWithComponentFactories<T> {
  * See [JIT API changes due to ViewEngine deprecation](guide/deprecations#jit-api-changes) for
  * additional context.
  */
-@Injectable()
+@Injectable({providedIn: 'root'})
 export class Compiler {
   /**
    * Compiles the given NgModule and all of its components. All templates of the components listed

diff --git a/packages/core/test/bundling/animations/bundle.golden_symbols.json b/packages/core/test/bundling/animations/bundle.golden_symbols.json
@@ -122,9 +122,6 @@
   {
     "name": "CommonModule"
   },
-  {
-    "name": "Compiler"
-  },
   {
     "name": "ComponentFactory"
   },
@@ -347,9 +344,6 @@
   {
     "name": "NgLocalization"
   },
-  {
-    "name": "NgModuleFactory2"
-  },
   {
     "name": "NgModuleRef"
   },
@@ -422,9 +416,6 @@
   {
     "name": "RuntimeError"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SELF_TOKEN_REGEX"
   },
@@ -677,6 +668,9 @@
   {
     "name": "collectNativeNodes"
   },
+  {
+    "name": "compileNgModuleFactory"
+  },
   {
     "name": "computeStaticStyling"
   },

diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -86,9 +86,6 @@
   {
     "name": "CommonModule"
   },
-  {
-    "name": "Compiler"
-  },
   {
     "name": "ComponentFactory"
   },
@@ -437,9 +434,6 @@
   {
     "name": "RuntimeError"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SERVER_TRANSITION_PROVIDERS"
   },

diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -92,9 +92,6 @@
   {
     "name": "CommonModule"
   },
-  {
-    "name": "Compiler"
-  },
   {
     "name": "ComponentFactory"
   },
@@ -431,9 +428,6 @@
   {
     "name": "RuntimeError"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SERVER_TRANSITION_PROVIDERS"
   },

diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -578,9 +578,6 @@
   {
     "name": "SAFE_URL_PATTERN"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SEGMENT_RE"
   },