New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch out ReachUI's MenuButton for RadixUI's DropDownMenu #120
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/andrewnt219/rent-near-me/JB4EJKwzkywtbGTitqpPuT8s8qfS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see we don't have to get around Reach implementation 👍.
The only significant change that is visible to the user: I changed Cost: testng out 2 libraries, filing 1 open source issue, tracking 1 on-going open source PR, multiple code refactorings and sleeping schedule. Worth it :) |
Changelog:
Text
component implementReact.forwardRef
UserMenu
back to asynchronously rendering ofMenuItem
s since Radix UI doesn't have the same bug as Reach UITemporarily disableIgnore the error on development for now (or you can right click on the error and choose to hide all errors fromreactStrictMode
innext.config.js
. See note below.react-dom
)Note:
Currently, in development,
react-dom
would complain about Radix UI's mismatchid
between client and server althoughIdProvider
has wrapped around the entire app as this insturction from Radix suggests. This does not happens in production. The bug has been documented here by someone else.Fortunately, a PR to resolve this has been merged 2 days ago. We could expect this issue to be fixed soon.
A temporary solution to dismiss. I'll create an urgent issue after this PR is merged to keep track of the fix (and docs) on Radix's side and update on our side asap.react-dom
's complaining is to disablereactStrictMode
The update would also include re-enablingreactStrictMode
.Reflection: