refactor: import timers, event, from node: #412

imranbarbhuiya · 2021-12-28T07:44:18Z

Changes

I changed the fillInString and Embed type to return null only when the input isn't a string or it's undefined.
changed global setTimeout, setInterval, EventEmiter to their respective node:* following refactor: import timers, process, and Buffer from node: discordjs/discord.js#7157
allow users to specify extraData type

Status

These changes have been tested and formatted properly.
This PR includes only documentation changes (JSDoc, README or typings), no code change.
This PR introduces some breaking changes.

Following https://github.com/discordjs/discord.js/blob/bf346e7fdfacfe8a70afbd639b24fa5f985305c8/src/structures/GuildMember.js#L448 We can just use `${w}` to mention the user.

typings/index.d.ts

imranbarbhuiya

I turned off my prettier but my ts organize import changed it 😅.

type change

2aad769

imranbarbhuiya changed the title ~~type change~~ refactor: import timers, event, from node: Dec 28, 2021

imranbarbhuiya added 3 commits December 28, 2021 13:54

Change @<${w.id}> to only ${w}

74863f7

Following https://github.com/discordjs/discord.js/blob/bf346e7fdfacfe8a70afbd639b24fa5f985305c8/src/structures/GuildMember.js#L448 We can just use `${w}` to mention the user.

allow undefined

a482c71

allow users to specify extradata type

6a2dad6

Nico105 reviewed Dec 28, 2021

View reviewed changes

typings/index.d.ts Outdated Show resolved Hide resolved

changed as suggested

5fea9bf

imranbarbhuiya requested a review from Nico105 December 29, 2021 07:35

Nico105 added 2 commits December 29, 2021 14:25

formatting of imports

1b70760

import formatting

503a97c

imranbarbhuiya commented Dec 29, 2021

View reviewed changes

Nico105 approved these changes Dec 29, 2021

View reviewed changes

Nico105 merged commit ddd4982 into Androz2091:develop Dec 29, 2021

imranbarbhuiya mentioned this pull request Jan 2, 2022

added extraData generic type to manager #413

Closed

6 tasks

Nico105 added documentation improvement labels Jan 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: import timers, event, from node: #412

refactor: import timers, event, from node: #412

imranbarbhuiya commented Dec 28, 2021 •

edited

imranbarbhuiya left a comment

refactor: import timers, event, from node: #412

refactor: import timers, event, from node: #412

Conversation

imranbarbhuiya commented Dec 28, 2021 • edited

Changes

Status

imranbarbhuiya left a comment

Choose a reason for hiding this comment

imranbarbhuiya commented Dec 28, 2021 •

edited