Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use try-with-resources for some streams #6956

Closed

Conversation

TacoTheDank
Copy link
Contributor

Description

  • Use try-with-resources for some streams per a SpotBugs suggestion. (I want to update the SpotBugs plugin to the latest version, and this is part of it.)

Checklist

@ByteHamster
Copy link
Member

How many changes are needed to support the update?

I think more important than adding new rules would be to fix our violations of the old rules and to re-enable the CI check (see #6941)

@TacoTheDank
Copy link
Contributor Author

@ByteHamster Luckily the SpotBugs version can be separated from the SpotBugs Gradle Plugin version, so we can update the plugin without needing to update SpotBugs itself, or vice versa (for the most part; newer (5.1.x) SpotBugs-plugin versions drop support for older SpotBugs versions).

@TacoTheDank
Copy link
Contributor Author

I just remembered this PR isn't actually related to SpotBugs like I thought. Its an old branch from over a year ago I had made and didn't do anything with. This is just using try-with-resources for some streams.

@ByteHamster
Copy link
Member

What's the state of this PR?

@ByteHamster ByteHamster added the Needs: Reply Issue or PR is awaiting follow-up, as requested by project maintainers. label May 3, 2024
Copy link

This PR will be closed when we don't get a reply within 7 days.

Copy link

This PR was closed because we didn't get a reply for 14 days.

@TacoTheDank
Copy link
Contributor Author

Sorry, I've been busy with school and other stuff. I intend to do this at some point, just need to get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Close reason: No reply Needs: Reply still Needs: Reply Issue or PR is awaiting follow-up, as requested by project maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants