Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: remove deprecated setFlags #7153

Closed
wants to merge 1 commit into from

Conversation

hades
Copy link
Contributor

@hades hades commented Apr 30, 2024

Per [1] these flags have been deprecated in API 26.

Tested with an API level 21 emulator: playback controls still work as expected.

[1] https://developer.android.com/reference/android/media/session/MediaSession#FLAG_HANDLES_MEDIA_BUTTONS

Description

Checklist

Per [1] these flags have been deprecated in API 26.

Tested with an API level 21 emulator: playback controls still work as expected.

[1] https://developer.android.com/reference/android/media/session/MediaSession#FLAG_HANDLES_MEDIA_BUTTONS
@ByteHamster
Copy link
Member

I would just keep the flags for now. When we rewrite the service we will probably remove them then. I don't think it is worth risking to break something (eg on older Android versions) just as a code cleanup. If you are interested in working more on the playback service, we can talk in more detail on the community call if you want. For example, we could restructure parts of the sleep timer as preparation for the new playback service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants