Fix android auto resume on reconnect issues

[hades]

Previously this was accomplished by manually subscribing to the Android Auto state. This was prone to failure, since it would only work as long as the service is running.

The correct way of handling this according to Android Auto docs[1] is to provide a valid PlaybackState when the service is bound. We accomplish this here by filling out the media session object whenever the media player is recreated.

Fixes #6698

[1] https://developer.android.com/training/cars/media/#initial-playback-state

Checklist

• I have read the contribution guidelines: https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
• I have performed a self-review of my code
• I have run the automated code checks using ./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug
• My code follows the style guidelines of the AntennaPod project: https://github.com/AntennaPod/AntennaPod/wiki/Code-style
• I have mentioned the corresponding issue and the relevant keyword (e.g., "Closes: #xy") in the description (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
• If it is a core feature, I have added automated tests

[ByteHamster]

Thanks for your changes related to the playback service. I'm not sure how much time we should spend on tweaking the existing service. In the near future, we should upgrade to media3 (see also #6608), which might require considerable changes to the playback service. Maybe some of these changes would then deprecate changes you are doing now.

Would you maybe be interested in working on #6608?

[hades]

I see your point. Upgrading to a currently supported version of the framework before trying to fix issues like this and (#6576) makes sense to me. However, in #6608 you said:

So I'm pretty sure that upgrading to media3 will not directly solve any of the issues we currently have, but will cause us a bunch of new issues. So this rewrite is quite low on my list currently.

Do I understand correctly, that your opinion has changed, and you would now prefer to update the library first?

At the same time, this specific issue has received a lot of user feedback (see forums and Play Store reviews), especially in the light of Google Podcasts dumping all of its users. I think it would be better for the project to include this fix. The amount of code changed is very small, and my intuition says the change should be relatively safe (however, of course, I'm very new to the codebase, so there may be unintended consequences).

Regarding #6608, let's continue the discussion there.

[ByteHamster]

So I'm pretty sure that upgrading to media3 will not directly solve any of the issues we currently have, but will cause us a bunch of new issues. So this rewrite is quite low on my list currently.

Do I understand correctly, that your opinion has changed, and you would now prefer to update the library first?

I still think upgrading to media3 won't fix all the problems with media resumption but I think we need to upgrade at some point anyway.

I think it would be better for the project to include this fix. The amount of code changed is very small, and my intuition says the change should be relatively safe (however, of course, I'm very new to the codebase, so there may be unintended consequences).

I also feel like it should be quite safe and am not against merging it. Will do some testing. Because you opened a bunch of playback service PRs, my idea with the message was just to avoid spending too much time ironing out bugs with the old service when we need to upgrade anyway eventually.

[hades]

Understood, thanks, all makes sense.

[ByteHamster]

Thanks! Will be released in 3.5.x

[tonytamsf]

Thanks @hades