Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows to ping about play reviews #7177

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

keunes
Copy link
Member

@keunes keunes commented May 10, 2024

Description

Set up two workflows to:

  • Add the 'Needs: Review reply' to an issue in case an added or edited issue comment contains the old or the new links to Play store reviews in the Google Play Console.
  • Add a comment tagging an organisation team on an issue when a new release is published if the issue a) is closed (assuming it's been implemented/addressed) and b) has the 'Needs: Review reply' label (assuming that there are links to Google Play reviews which need a reply.

Once replied, the user should remove the label in order to avoid being tagged again.
For this to work, I have also set up the 'review-replyers' team, which when tagged should ping all team members (currently only me).

Checklist

owner: context.repo.owner,
repo: context.repo.repo,
issue_number: issue.number,
body: 'This feature or fix is now released! @AntennaPod/review-replyers, time to inform relevant reviews in Google Play console (please see links in one or more of the comments above).'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think this part is quite hard to do. We often close issues on the develop branch after the feature freeze of the beta version. So this would tag things that are not actually released.

Copy link
Member Author

@keunes keunes May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look.
This workflow only runs when you create a public release (see line 4), i.e. when it's available on Google Play. Only at that point it posts messages on closed issues (thus not as soon as the issue gets closed).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup but when creating the release, we have already closed additional issues that are not in that release but the release after that

For example, "download without subscribing" is closed but will be in 3.5.0, not 3.4.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's what you mean. Right.

Then either we should start linking issues with milestones, or I get tagged twice on some issues (which is not a huge problem).

@keunes
Copy link
Member Author

keunes commented May 11, 2024

Actually, I just thought of another approach to get the list of issues/PRs which are actually included in the release: replicate a process like in https://github.com/AntennaPod/AntennaPod/blob/develop/scripts%2FgetChangelog.py

@ByteHamster
Copy link
Member

ByteHamster commented May 18, 2024

Yeah, using that script sounds more reliable. Maybe it could even just add a column to the changelog output checking if the issue in the PR description contains a review?

@keunes
Copy link
Member Author

keunes commented May 18, 2024

Maybe it could even just add a column to the changelog output checking if the issue in the PR description contains a review?

Hmm, that might be an idea. We could apply the label at issue level still, and then check for that. Otherwise we'd have to cycle through all comments in the script, and there's already a delay to not hit the rate limit.

@ByteHamster
Copy link
Member

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants