Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecation warning when using entry points like dict in some python environments #473

Merged
merged 7 commits into from Feb 8, 2022
Merged

fix: deprecation warning when using entry points like dict in some python environments #473

merged 7 commits into from Feb 8, 2022

Conversation

antazoey
Copy link
Contributor

@antazoey antazoey commented Feb 5, 2022

What I did

fixes: #467

How I did it

try/catch using groups.

How to verify it

ape

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey
Copy link
Contributor Author

antazoey commented Feb 5, 2022

mypy failing because of #475

fubuloubu
fubuloubu previously approved these changes Feb 6, 2022
View reviewed changes
src/ape/_cli.py Show resolved Hide resolved
@antazoey antazoey merged commit 431f700 into ApeWorX:main Feb 8, 2022
@antazoey antazoey deleted the save-deprec branch February 8, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Handle deprecation of importlib SelectableGroups dict interface
2 participants
@antazoey @fubuloubu