Nullability fixes for chaos outcome strategy

[martintmk]

Details on the issue fix or feature implementation

Fixing some incorrect nullability annotatations.

Confirm the following

• I started this PR by branching from the head of the default branch
• I have targeted the PR to merge into the default branch
• I have included unit tests for the issue/feature
• I have successfully run a local build

[peter-csala]

@martintmk If you want I can help with this PR by fixing the tests (and resolving the merge conflict).

[martintmk]

@martintmk If you want I can help with this PR by fixing the tests (and resolving the merge conflict).

That would be great as I won't be able to touch this in next two weeks (vacation).

[peter-csala]

@martintmk If you want I can help with this PR by fixing the tests (and resolving the merge conflict).

That would be great as I won't be able to touch this in next two weeks (vacation).

Sure, no problem. Enjoy your vacation! 😏

Please allow me (@peter-csala) to contribute to your branch.

[martincostello]

The branch is here rather than in a fork, so I'm not sure that's doable.

If you want to pick up the work, copy the branch locally into your fork and start a new PR.

[peter-csala]

The branch is here rather than in a fork, so I'm not sure that's doable.

If you want to pick up the work, copy the branch locally into your fork and start a new PR.

Ohh okay, I thought Martin was working on a fork as well.

I'll create a new PR then.

[martintmk]

@martincostello This one should be ready, after this is merged we can go ahead with 8.4.0

[martincostello]

I'm not convinced this was worth doing in the end as the net effect is just a little less code at the expense of allowing the compiler to assign null when that isn't actually allowed, so what is there already feels more correct to me to be honest, but if it makes it consistent with all the other options types, we might as well change it.