Update to .NET 9 SDK #2003
Draft
Update to .NET 9 SDK #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
added
dependencies
martincostello
added a commit
to martincostello/Polly
that referenced
this pull request
Mar 1, 2024
- Fix CA1849 warning from updating snippets to .NET 8. - Fix IDE0034 warning identified by the .NET 9 SDK in App-vNext#2003.
martincostello
added a commit
that referenced
this pull request
Mar 1, 2024
- Update various sample projects from `net7.0` to `net8.0`. - Fix CA1849 warning from updating snippets to .NET 8. - Fix IDE0034 warning identified by the .NET 9 SDK in #2003.
martincostello
force-pushed
the
dotnet-vnext
branch
from
a29ccc2
to
7ca1b0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
=======================================
Coverage ? 83.65%
=======================================
Files ? 311
Lines ? 7096
Branches ? 1050
=======================================
Hits ? 5936
Misses ? 789
Partials ? 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
force-pushed
the
dotnet-vnext
branch
from
336f454
to
7952a24
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
from
7952a24
to
ee658b4
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
2 times, most recently
from
6200a8c
to
a26bc60
Compare
martincostello
commented
Apr 12, 2024
Comment on lines
13
to
14
| <!-- HACK net9.0 compilation for the tests fails due to missing Task.Delay() extension for TimeProvider without this reference --> | ||
| <PackageReference Include="Microsoft.Bcl.TimeProvider" Condition="$([MSBuild]::IsTargetFrameworkCompatible($(TargetFramework), 'net9.0'))" /> |
There was a problem hiding this comment.
@martintmk Any idea what's going on with this? Without an explicit reference to this package, I can't get the tests to compile for net9.0.
The only change I can see that might explain it is this from dotnet/extensions#5058.
martincostello
added a commit
to martincostello/Polly
that referenced
this pull request
Apr 12, 2024
Fix IDE0057 warnings identified in App-vNext#2003.
This was referenced Apr 12, 2024
martincostello
added a commit
that referenced
this pull request
Apr 12, 2024
Fix IDE0057 warnings identified in #2003.
martincostello
force-pushed
the
dotnet-vnext
branch
from
e823391
to
36ecb34
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
from
36ecb34
to
82a3c08
Compare
martincostello
force-pushed
the
dotnet-vnext
branch
2 times, most recently
from
bee5858
to
eeac2c2
Compare
- Update to preview 1 of the .NET 9 SDK. - Target `net8.0` and `net9.0` in tests, samples and benchmarks. - Remove `net6.0` and `net7.0` targets from tests, samples and benchmarks. - Simplify AoT properties. - Only analyse for AoT for .NET 8+ to resolve new warning. - Force docfx to use .NET 9 SDK. - Fix new IDE0034 warning.
Just validate with `net9.0` to avoid complexity of publishing the AoT app twice when Polly will just use `net8.0` both times anyway.
Skip test that breaks the VSTest process in release mode for .NET 9.
Reduce coverage threshold while test skipped.
Add link to issue for skipped test.
Update to preview 2 of the .NET 9 SDK.
* Update .NET SDK Update .NET SDK to version 9.0.100-preview.3.24204.13. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> * Bump Microsoft.Extensions.TimeProvider.Testing Bump Microsoft.Extensions.TimeProvider.Testing for .NET 9 preview 3. --------- Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> Co-authored-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
Test no longer appears to fail with .NET 9 preview 3.
Accidentally deleted, rather than updated.
martincostello
force-pushed
the
dotnet-vnext
branch
from
f1bb09c
to
7cd8e0f
Compare
Update to preview 4 of .NET 9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long-lived PR for testing .NET 9 until the stable release in November 2024.
net9.0is explicitly not being added as a new TFM for the packages we ship to NuGet.org.Changes include:
net8.0andnet9.0in tests, samples and benchmarks.net6.0andnet7.0targets from tests, samples and benchmarks as they will both be out-of-support by November 2023.