Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Upon deleting Grid, Board or Calendar from the sidebar, no banner to restore or delete permanently appears. #3471

Open
MayurSMahajan opened this issue Sep 20, 2023 · 9 comments · May be fixed by #3646
Open

[Bug] Upon deleting Grid, Board or Calendar from the sidebar, no banner to restore or delete permanently appears. #3471

MayurSMahajan opened this issue Sep 20, 2023 · 9 comments · May be fixed by #3646
Labels
2024 calendar features related to the calendar database grid features related to the table-view database kanban board features related to the board-view database

Comments

@MayurSMahajan
Copy link
Collaborator

Bug Description

When you delete a document in AppFlowy you see a dialog appear at the top of your document:
image

No such dialog appears when you delete a Grid, Board or Calendar. Since there is no indicator of the file being deleted, the user may continue editing the Grid/Board/Calendar without noticing that they have deleted it.

This is how it appears:

delete_bug.mp4

How to Reproduce

  1. Open AppFlowy
  2. Create a new Grid/Board/Calendar
  3. Delete the newly created item from the sidebar
  4. Observe how the deleted item still appears without any indicator of it being deleted.
  5. Observe how you can still change the deleted item's content.

Expected Behavior

Some indication that the Grid/Board/Calendar is deleted and thus should not be modified.

Operating System

Windows 11

AppFlowy Version(s)

1.0.0

Screenshots

Refer to the video attached above.

Additional Context

No response
@MayurSMahajan MayurSMahajan added good first issue for experienced devs for the experienced community developers to claim grid features related to the table-view database kanban board features related to the board-view database calendar features related to the calendar database hacktoberfest labels Sep 20, 2023
@Azanul
Copy link

Azanul commented Sep 26, 2023

May I take this up?

@richardshiue
Copy link
Collaborator

Assigned @Azanul, have fun!

@0xJaskeerat
Copy link
Contributor

Hey @MayurSMahajan @richardshiue , Can I try my hands on this , if @Azanul is not able to do

@MayurSMahajan
Copy link
Collaborator Author

@Azanul are you still working on this?

@Azanul
Copy link

Azanul commented Oct 4, 2023

@Azanul are you still working on this?

Yes. I haven't used block before that's why I'm taking some time, but I'll raise the PR in a couple of days.

@Azanul Azanul linked a pull request Oct 8, 2023 that will close this issue
Open
4 tasks
@SharmaDhruv2511
Copy link
Contributor

is this issue still open?? want to contribute to it??

@MayurSMahajan
Copy link
Collaborator Author

@Azanul's PR is being review, look for other issues.

@SharmaDhruv2511
Copy link
Contributor

is this issue still open??

@Xazin
Copy link
Collaborator

Xazin commented Oct 28, 2023

is this issue still open??

There is an open PR for this, thus it's not closed yet, but work are done/in progress.

@annieappflowy annieappflowy added 2024 and removed good first issue for experienced devs for the experienced community developers to claim hacktoberfest labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2024 calendar features related to the calendar database grid features related to the table-view database kanban board features related to the board-view database
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: no banner to restore or delete permanently appears Azanul/AppFlowy
7 participants
@annieappflowy @Azanul @Xazin @MayurSMahajan @richardshiue @SharmaDhruv2511 @0xJaskeerat