fix: no banner to restore or delete permanently appears

[Azanul]

Appflowy-3471.mov

Feature Preview

Fixes #3471

PR Checklist

• My code adheres to AppFlowy's Conventions
• I've listed at least one issue that this PR fixes in the description above.
• I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
• All existing tests are passing.

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (890f52a) 69.61% compared to head (5882041) 11.14%.
Report is 138 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3646       +/-   ##
===========================================
- Coverage   69.61%   11.14%   -58.48%     
===========================================
  Files         502      600       +98     
  Lines       23253    27715     +4462     
===========================================
- Hits        16187     3088    -13099     
- Misses       7066    24627    +17561     

Flag	Coverage Δ
appflowy_flutter_integrateion_test	?
appflowy_flutter_unit_test	11.14% <0.00%> (-1.54%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...wy_flutter/lib/plugins/document/document_page.dart	0.00% <0.00%> (-76.20%)	⬇️
...lugins/database_view/application/tar_bar_bloc.dart	0.00% <0.00%> (-95.13%)	⬇️
frontend/appflowy_flutter/lib/plugins/banner.dart	0.00% <0.00%> (ø)
...ib/plugins/database_view/tar_bar/tab_bar_view.dart	0.00% <0.00%> (-92.86%)	⬇️

... and 535 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[LucasXu0]

@Azanul I have pushed the code for the 'expanded banner.' Please take a look. However, I noticed that you didn't implement the logic for permanently deleting the database view.

[Azanul]

@Azanul I have pushed the code for the 'expanded banner.' Please take a look. However, I noticed that you didn't implement the logic for permanently deleting the database view.

Thanks a lot for the assist! I had difficulty implementing these two things, I asked for help in the discord server but didn't find any

[LucasXu0]

@Azanul I have pushed the code for the 'expanded banner.' Please take a look. However, I noticed that you didn't implement the logic for permanently deleting the database view.

Thanks a lot for the assist! I had difficulty implementing these two things, I asked for help in the discord server but didn't find any

For the 'delete permanently' issue, you can refer to the logic used in the document page or comment on the PR if you have any questions.

[richardshiue]

Hey there @Azanul, thanks for contributing! I have some feedback:

• deleting a view (not the entire database) also makes the banner show even on the remaining view. (1. create a grid 2. add a new board view on the tab bar 3. delete the board view via the tab bar 4. confirm delete view 5. see that the grid view is shown but the banner appears)
• if it were up to me, I'd move the banner widget out of the documents directory since it is now used by the database as well

[Azanul]

For the 'delete permanently' issue, you can refer to the logic used in the document page or comment on the PR if you have any questions.

@LucasXu0 I'm unable to do clean rebuild after pulling

[Azanul]

I messed up trying to amend git messages which were cause the CI to fail. I've implemented the logic completely this time.
I again had difficulty expanding the banner, @LucasXu0 please do it if you don't mind.

[richardshiue]

I think the behavior is still weird, referring to the first point in my previous comment

[Azanul]

I think the behavior is still weird, referring to the first point in my previous comment

Which would be better?

1. No banner on deleting from tab bar
2. Banner opens and the view stays i.e., doesn't force close

[richardshiue]

I think the first option is better.

[Azanul]

I think the first option is better.

Done