feat: Support Panes for AppFlowy #3337
Draft
+2,914
−820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat-panes-2312
…eat-panes-2312
…eat-panes-2312
|
@squidrye I have merged the editor optimization into the main branch. You can now rebase the latest main branch and test the performance of multiple editor's windows again. |
…eat-panes-2312
squidrye
force-pushed
the
feat-panes-2312
branch
from
8610457
to
09811ef
Compare
Xazin
reviewed
Sep 13, 2023
...lowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart
Outdated
Show resolved
Hide resolved
Xazin
reviewed
Sep 13, 2023
frontend/appflowy_flutter/lib/workspace/application/panes/panes_cubit/panes_cubit.dart
Outdated
Show resolved
Hide resolved
Xazin
reviewed
Sep 13, 2023
frontend/appflowy_flutter/lib/workspace/application/panes/panes_service.dart
Outdated
Show resolved
Hide resolved
Xazin
reviewed
Sep 13, 2023
frontend/appflowy_flutter/lib/workspace/application/tabs/tabs.dart
Outdated
Show resolved
Hide resolved
Xazin
reviewed
Sep 13, 2023
frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart
Outdated
Show resolved
Hide resolved
squidrye
force-pushed
the
feat-panes-2312
branch
from
fc9ccb8
to
b72d4ca
Compare
squidrye
force-pushed
the
feat-panes-2312
branch
from
615ad01
to
2524c8b
Compare
Xazin
approved these changes
Nov 9, 2023
frontend/appflowy_flutter/integration_test/board/board_row_test.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/integration_test/database_calendar_test.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/integration_test/board/board_row_test.dart
Outdated
Show resolved
Hide resolved
Need left padding + icon on hover needs to be correct color 
Maybe we should double the minimum width of panes 
We can improve this later I guess, but I believe the read-only banner should be not inside the content of the view, but if possible just below the Title Bar. |
squidrye
force-pushed
the
feat-panes-2312
branch
from
acbdbf0
to
563b362
Compare
squidrye
force-pushed
the
feat-panes-2312
branch
from
1411e6d
to
c152e1e
Compare
|
what blocks this PR from merging? |
Due to the sheer size and complexity of the work here, I requested a secondary review from @LucasXu0 , but it was in the middle of the work on mobile, so it was pushed down in priority for a while. |
…eat-panes-2312
squidrye
force-pushed
the
feat-panes-2312
branch
2 times, most recently
from
31a6dca
to
9b5f834
Compare
|
Thanks @squidrye for the merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
AwesomeScreenshot-9_1_2023.1.35.57PM.mp4
#2312 This PR targets implementation of multi-panes
cc @Xazin
#3237 Reopening this PR, had to delete my older fork because I had pushed private code due to local git misconfiguration 😢
PR Checklist
Todos