feat: emoji shortcut feature #4111
Open
+542
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: emoji shortcut service * fix: orginial emoji command shortcut * fix: editor_page command * fix: postioning of the emoji picker * fix: emoji size and number per row * refactor: Removed unused dart math package * fix: postioning of emoji menu * refactor: emoji test * refactor: emoji test * feat: emoji shortcut service * fix:emoji shortcut insert tests * Revert "fix:emoji shortcut insert tests" This reverts commit 7391e01. * Revert "feat: emoji shortcut service" This reverts commit 657bb35. * fix:vcode settings.json restore to default * fix:vcode settings.json restore to default * refactor: integration emoji shortcut command tests * refactor: removing unwanted import in the emoji_shortcut_service.dart file * refactor: emoji shortcut command and builder * refactor: emoji shortcut command and builder * refactor: emoji shortcut insert test. Keydown mapping * refactor: document_emoji_shortcut_test * fix: emoji shortcut integration tests * chore: optimzations * style:pemoji shortcut builder * refactor: emoji_shortcut_service * test: finally managed to pass tests * test: document emoji shortcut command * refactor: emoji shortcut command * refactor: emoji shortcut service * refactor: emoji shortcut service * fix: reverting example/macos/podfile file * test: tested with arrow keys
|
|
Xazin
reviewed
Dec 7, 2023
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart
Outdated
Show resolved
Hide resolved
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_builder.dart
Outdated
Show resolved
Hide resolved
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_builder.dart
Outdated
Show resolved
Hide resolved
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_builder.dart
Outdated
Show resolved
Hide resolved
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_builder.dart
Outdated
Show resolved
Hide resolved
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_builder.dart
Outdated
Show resolved
Hide resolved
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_builder.dart
Outdated
Show resolved
Hide resolved
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_service.dart
Outdated
Show resolved
Hide resolved
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_service.dart
Outdated
Show resolved
Hide resolved
Tony-MK
commented
Dec 12, 2023
.../lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_shortcut_builder.dart
Show resolved
Hide resolved
|
I'll have to test something before leaving a final approval, I'll see if I can get to it this weekend, sorry for the wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
Closes: #2797
PR Checklist