Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial github release version checker #4792

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Mar 1, 2024

Relates: #3639

This is a flawed version checker. It is based on GitHubs REST API, unauthenticated requests are rate limited to 60 requests per hour.

If for any reason the check should fail, eg. no network connection, hit rate limit, or similar, we silently fail and assume the application is up-to-date.

The check only happens once on application startup for now, in the future we can support manually checking for updates and storing the time of the last check.

For more information see:
https://docs.github.com/en/rest/rate-limit/rate-limit?apiVersion=2022-11-28
https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#get-the-latest-release

Feature Preview

Screenshot 2024-03-01 at 23 15 33 Screenshot 2024-03-01 at 23 13 09

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@LucasXu0 LucasXu0 self-requested a review March 2, 2024 14:52
@Xazin Xazin added v0.5.4 and removed v0.5.3 labels Mar 21, 2024
@Xazin Xazin marked this pull request as draft April 3, 2024 07:34
@Xazin Xazin removed the v0.5.4 label Apr 3, 2024
@Xazin
Copy link
Collaborator Author

Xazin commented Apr 12, 2024

Note: the reason I keep pushing this, is because I need to do some design work and it's not a high-priority.

@Xazin
Copy link
Collaborator Author

Xazin commented May 17, 2024

I'll brush it up and finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request v0.5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants