Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: video block support #5199

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Apr 24, 2024

Tested on Linux (Ubuntu), MacOS, Windows, Android & iOS

Feature Preview

Seems sync causes the video to seem as if it's being played when it's actually paused. I haven't been able to find a good fix yet.

0969c8ed-d3f6-4357-b48a-f9727ce7f92b.mp4

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Apr 24, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports link
Missing translation 175 contribute (via Fink 🐦)

@Xazin Xazin force-pushed the feat/video-block-support branch 3 times, most recently from 4842269 to 3e45cf5 Compare April 24, 2024 09:10
@Xazin
Copy link
Collaborator Author

Xazin commented Apr 24, 2024

Linux CI failing due to actions/runner-images#7210

Waiting for resolution.

@Xazin
Copy link
Collaborator Author

Xazin commented May 6, 2024

I'm currently waiting on a computer, I'll be able to install Linux on it and hopefully resolve issues with Linux platform through testing.

@Xazin Xazin added the v0.5.8 label May 13, 2024
@Xazin Xazin force-pushed the feat/video-block-support branch from 4c93556 to f49b636 Compare May 13, 2024 18:47
@@ -19,47 +19,55 @@ AppDir:
exec_args: $@
apt:
arch:
- amd64
- amd64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Flatpak file as well.

https://github.com/flathub/io.appflowy.AppFlowy

@Xazin Xazin added v0.5.9 and removed v0.5.8 labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants