New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: video block support #5199
Open
Xazin
wants to merge
13
commits into
AppFlowy-IO:main
Choose a base branch
from
Xazin:feat/video-block-support
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
lint rule | new reports | link |
---|---|---|
Missing translation | 175 | contribute (via Fink 🐦) |
Xazin
force-pushed
the
feat/video-block-support
branch
3 times, most recently
from
April 24, 2024 09:10
4842269
to
3e45cf5
Compare
Linux CI failing due to actions/runner-images#7210 Waiting for resolution. |
Xazin
force-pushed
the
feat/video-block-support
branch
from
April 24, 2024 11:06
5503f51
to
4496248
Compare
I'm currently waiting on a computer, I'll be able to install Linux on it and hopefully resolve issues with Linux platform through testing. |
Xazin
force-pushed
the
feat/video-block-support
branch
from
May 13, 2024 18:47
4c93556
to
f49b636
Compare
LucasXu0
reviewed
May 16, 2024
@@ -19,47 +19,55 @@ AppDir: | |||
exec_args: $@ | |||
apt: | |||
arch: | |||
- amd64 | |||
- amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the Flatpak file as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Linux (Ubuntu), MacOS, Windows, Android & iOS
Feature Preview
Seems sync causes the video to seem as if it's being played when it's actually paused. I haven't been able to find a good fix yet.0969c8ed-d3f6-4357-b48a-f9727ce7f92b.mp4
PR Checklist