Fix for #629 #725
Open
Fix for #629 #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the following metrics:
```json
{
"contexts": [
{
"apdexScores": [],
"context": "MyContext",
"counters": [],
"gauges": [
{
"value": 1,
"name": "NameOfMetric|PipelineId:1",
"tags": {
"pipelineId": "1"
}
},
{
"value": 1,
"name": "NameOfMetric|PipelineId:2",
"tags": {
"pipelineId": "2"
}
}
],
"histograms": [],
"bucketHistograms": [],
"meters": [],
"timers": [],
"bucketTimers": []
}
],
"timestamp": "2022-01-19T13:29:40.9729471Z"
}
```
Given the following code...
```cs
var filter = new MetricsFilter().WhereTaggedWithKeyValue(new TagKeyValueFilter { { "pipelineId", "`" } });
var filteredMetrics = metrics?.Filter(filter);
```
I woulf expect `filteredMetrics` to have a single gauge value. The current dev branch returns both values as the tag-key exist for both values. The code I'm changing with this PR is either a bug (AppMetrics#629?) or its behavior is unintuitive.
|
Is there any particular reason or which this change is not merged yet? |
|
Checks failed. Also I've mentioned I no longer have time to maintain the project, and given projects like opentelemetry I'm not sure how much value there is anymore with AppMetrics. Looking for maintainers to continue to project if still valuable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following metrics:
{ "contexts": [ { "apdexScores": [], "context": "MyContext", "counters": [], "gauges": [ { "value": 1, "name": "NameOfMetric|PipelineId:1", "tags": { "pipelineId": "1" } }, { "value": 1, "name": "NameOfMetric|PipelineId:2", "tags": { "pipelineId": "2" } } ], "histograms": [], "bucketHistograms": [], "meters": [], "timers": [], "bucketTimers": [] } ], "timestamp": "2022-01-19T13:29:40.9729471Z" }Given the following code...
I woulf expect
filteredMetricsto have a single gauge value. The current dev branch returns both values as thepipelineIdtag (the key) exist for both values. The code I'm changing with this PR is either a bug (#629?) or its behavior is unintuitive.