New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cmake #42
Open
spyridon97
wants to merge
12
commits into
ArashPartow:master
Choose a base branch
from
spyridon97:use-cmake
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use cmake #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to determine the ExprTk version through the git tag.
Also move exprtk.hpp into an include folder
Also move the tests in a tests directory
Also move examples into an examples folder
Also move benchmarks into an benchmarks folder
There could be a problem with the circle ci, i am not sure if cmake is installed by default. |
spyridon97
force-pushed
the
use-cmake
branch
from
February 25, 2023 21:56
3b6d108
to
36a81f7
Compare
Also update the source structure
spyridon97
force-pushed
the
use-cmake
branch
from
February 25, 2023 22:01
36a81f7
to
05fd686
Compare
Any progress on this ? |
The PR is ready to be merged. I am waiting on @ArashPartow . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pull-request to incorporate cmake in the build, and installation process of the library.
The version of the library is extracted from the git tag.