ConnectionOptions fixes #3254
Open
ConnectionOptions fixes #3254
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SerialReader thread does nothing to our new port until it is added to the list of Comports, but we cannot add it to that list until the BaseStream is open, or the SerialReader will dispose of the port.
The theme would show correctly for the main connection button, but if anything else, like ConnectionOptions, launched the connection, the progress bar would show up unthemed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching redundant links with
ConnectionOptions, it would always use the old-school param download, and the theme of the progress window would be wrong.