Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMapMarkerBase: add options for transparent MAVs #3263

Merged
merged 2 commits into from May 16, 2024

Conversation

robertlong13
Copy link
Collaborator

This allows the user to select whether other MAVs, or other instances of the same MAV on redundant links, should be hidden from the map, or displayed as transparent to be less distracting, or displayed as normal. The setting defaults to normal.

Additionally, added settings on the Config > Planner page to allow control over settings that were previously only available with config hacking.

Shown below is the image of one aircraft coming in over three redundant links (Radio, LTE, and SatCom) using the Transparent display option.
Screenshot 2023-12-22 164018

Screenshot of new config options
Screenshot 2023-12-22 163050

I had to do some funny naming nonsense for the Quad map marker. This was done keeping two things in mind:

  1. Avoid constructing pens and brushes over and over assuming there is some performance penalty for that.
  2. Avoid breaking plugins that might override the pen colors. Don't want to rename the existing bluepen, greenpen, or greenbrush.

@meee1
Copy link
Contributor

meee1 commented Jan 12, 2024

has this been tested on android build? ie it actually runs

@robertlong13
Copy link
Collaborator Author

has this been tested on android build? ie it actually runs

I have not. I just spent a bit of time trying to, but I can't get master to run on Android right now. The CI is not actually generating the APK anymore, only an AAB. Trying to build locally, but freezing on splash (master is).

I may be doing something wrong (opening MissionPlannerLib.sln, building everything, and running the Android project). Tried on both an emulated tablet and my phone. Tried both running it through ADB and by manually installing the apk. Seems to be stuck waiting on WriteExternalStorage permission, but I only got a popup for location permission.

This allows the user to select whether other MAVs, or other instances of
the same MAV on redundant links, should be hidden from the map, or
displayed as transparent to be less distracting, or displayed as normal.
The setting defaults to normal.

Additionally, added settings on the Config > Planner page to allow
control over settings that were previously only available with config
hacking.
Allows testing the app before merging.
@robertlong13
Copy link
Collaborator Author

@meee1 I had to modify CI so it could give me an unsigned APK that I could self-sign and install (I cannot, for the life of me, figure out what I'm doing wrong on local building it). It works!
Screenshot_20240515-034608

@meee1 meee1 merged commit 1ddb99e into ArduPilot:master May 16, 2024
4 of 6 checks passed
@robertlong13 robertlong13 deleted the pr/inactive_ac_icons branch May 16, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants