Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlightPlanner : tweak prefetch, Resolves #2591, resolves #2483 #3320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Godeffroy
Copy link
Contributor

@Godeffroy Godeffroy commented Apr 3, 2024

When prefetching, do not download tile if file already exist
Add minZoom input in prefetch (like maxZoom)
image

Use Parallel.For instead of For to get tiles faster !

Using original for loop to download world from zoom 5 to 1 :
image
Middle of land at zoom 12 to 10 :
image

Using Parallel.For loop to download world from zoom 5 to 1 :
image
Middle of land at zoom 12 to 10 :
image

@Godeffroy Godeffroy changed the title FlightPlanner : tweak prefetch FlightPlanner : tweak prefetch, resolves #2591, resolves #2483 Apr 3, 2024
@Godeffroy Godeffroy changed the title FlightPlanner : tweak prefetch, resolves #2591, resolves #2483 FlightPlanner : tweak prefetch, Resolves #2591, resolves #2483 Apr 3, 2024
@Godeffroy Godeffroy marked this pull request as ready for review April 3, 2024 16:23
@meee1
Copy link
Contributor

meee1 commented Apr 4, 2024

there is a potential issue here
and that's with googles TOS
300 QPM (requests per minute) per IP address.

the check for existing file is all ok. its just the parallel for that's the problem

@Godeffroy
Copy link
Contributor Author

Godeffroy commented Apr 4, 2024

I understand the potential issue, but without modification, we can already get more than 300 tiles per minutes :
image

I think in the TOS, the limit is 30 000 ?
image

I could limit the parallelism with the option MaxDegreeOfParallelism = 4 ?

When prefetching, do not download tile if file already exist
Add minZoom input in prefetch (like maxZoom)
Use Parallel.For instead of For to get tiles faster !
@Godeffroy
Copy link
Contributor Author

Godeffroy commented Apr 9, 2024

I removed the parallel for (and also rebased on master).

@meee1
Copy link
Contributor

meee1 commented May 16, 2024

whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants