Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: automatically update the repo every 5 days #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Williangalvani
Copy link
Contributor

This seems to be deleting some of Copter 3.5 files? maybe it is the python version? maybe I'm missing some dependency?
see Williangalvani@b3d6b52

@clydemcqueen
Copy link
Contributor

Looks like a bug in the json emitter in param_parse.py.

clyde@topside:~/ap/upstream (Copter-4.1)$ ./Tools/autotest/param_metadata/param_parse.py --vehicle ArduCopter --format all
clyde@topside:~/ap/upstream (Copter-4.1)$ ll -t
total 5664
-rw-rw-r--   1 clyde clyde  961282 Feb 26 11:42 ParameterMetaData.xml
-rw-rw-r--   1 clyde clyde  595035 Feb 26 11:42 Parameters.md
-rw-rw-r--   1 clyde clyde 1748182 Feb 26 11:42 Parameters.rst
-rw-rw-r--   1 clyde clyde  991226 Feb 26 11:42 Parameters.html
-rw-rw-r--   1 clyde clyde 1198335 Feb 26 11:42 apm.pdef.xml
-rw-rw-r--   1 clyde clyde    1948 Feb 26 11:42 apm.pdef.json
drwxrwxr-x  18 clyde clyde    4096 Feb 26 11:36 ./
drwxrwxr-x   8 clyde clyde    4096 Feb 26 11:35 .git/
drwxrwxr-x   2 clyde clyde    4096 Feb 26 11:35 mk/
drwxrwxr-x   9 clyde clyde    4096 Feb 26 11:35 modules/
...

I see json_from_xml.py -- perhaps this is a known bug?

@clydemcqueen
Copy link
Contributor

Addresses #2

@Williangalvani
Copy link
Contributor Author

@patrickelectric thoughts?

@HTRamsey
Copy link

What's the plan here? I'd like to update QGC with either this or just use the run_param_parse.py tool separately.

@patrickelectric
Copy link
Member

I'll investigate what is going on

@patrickelectric
Copy link
Member

This should be fixed by #5

scripts/run_param_parse.py Outdated Show resolved Hide resolved
# Add any other dependencies here

- name: Run Python script
run: python scripts/run_param_parse.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsom_from_xml also needs to run, the problem is that old firmwares failed on generate json files correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is json_from_xml being called ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed we didnt need that anymore after the previous prs. I'll check this tomorrow

@patrickelectric
Copy link
Member

Please update over master, should contain all necessary fixes for this patch to work

@HTRamsey
Copy link

@patrickelectric thanks for looking into this so quickly

- name: Commit and push if changed
run: |
git config --global user.email "CI@example.com"
git config --global user.name "CI"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the official git bot:

        git config --global user.name 'Git bot'
        git config --global user.email 'bot@noreply.github.com'

@patrickelectric
Copy link
Member

patrickelectric commented Mar 14, 2024

@Williangalvani it appears that there is something wrong on the PR , is deleting copter, plane and sub 4.0. It's also weird to be modifying the files, since it was updates a couplem of hours ago from the last version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants