New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: automatically update the repo every 5 days #4
base: main
Are you sure you want to change the base?
Conversation
Looks like a bug in the json emitter in
I see |
Addresses #2 |
@patrickelectric thoughts? |
What's the plan here? I'd like to update QGC with either this or just use the run_param_parse.py tool separately. |
I'll investigate what is going on |
This should be fixed by #5 |
.github/workflows/deploy.yaml
Outdated
# Add any other dependencies here | ||
|
||
- name: Run Python script | ||
run: python scripts/run_param_parse.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsom_from_xml also needs to run, the problem is that old firmwares failed on generate json files correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is json_from_xml being called ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed we didnt need that anymore after the previous prs. I'll check this tomorrow
Please update over master, should contain all necessary fixes for this patch to work |
@patrickelectric thanks for looking into this so quickly |
aee450a
to
41f26af
Compare
.github/workflows/deploy.yaml
Outdated
- name: Commit and push if changed | ||
run: | | ||
git config --global user.email "CI@example.com" | ||
git config --global user.name "CI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the official git bot:
git config --global user.name 'Git bot'
git config --global user.email 'bot@noreply.github.com'
@Williangalvani it appears that there is something wrong on the PR , is deleting copter, plane and sub 4.0. It's also weird to be modifying the files, since it was updates a couplem of hours ago from the last version |
This seems to be deleting some of Copter 3.5 files? maybe it is the python version? maybe I'm missing some dependency?
see Williangalvani@b3d6b52