Default to harmonic #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* And clean up instructions * rosdep now resolves correctly Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Ryanf55
added
documentation
|
@pulak-gautam Any chance you could test these changes? |
| <exec_depend>ros_gz_sim</exec_depend> | ||
| <exec_depend>ros_gz_bridge</exec_depend> | ||
| <!-- TODO this installs ignition --> |
There was a problem hiding this comment.
Do we want to keep this if rosdep installs ignition? It may be better to refer users to the Gazebo Sim documentation for running non-standard ROS 2 / Gazebo combos: https://gazebosim.org/docs/latest/ros_installation.
There was a problem hiding this comment.
I was not sure. If there were other rosdep keys, I would say yes, but I haven't found them. We still want to ensure the build order is correct. Perhaps I should ask on the discord server.
| wget https://raw.githubusercontent.com/ArduPilot/ardupilot_gz/main/ros2_gz.repos | ||
| vcs import --recursive < ros2_gz.repos | ||
| cd ~/ros2_ws | ||
| mkdir src |
There was a problem hiding this comment.
Don't need this as created above in L31.
srmainwaring
requested changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
harmonic