Remove comment about Google-maps timezone. #5909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IamPete1 , I've had some trouble with the timezone calculation and was able to work out that time-zone info support is pretty inconsistent across browsers and operating systems. What do you think about removing this line? It tripped me up the first few times I tried to call in to the weekly devcall - I thought the weekly ArduPilot meetings were just inactive. |
Hwurzburg
reviewed
Apr 28, 2024
|
@Hwurzburg , I'm sorry for the late response. I'm not opposed to your suggestion, but I do wonder if the AP wiki should be documenting the features and bugs of an external web service, vs keeping it simple. |
When the timezone known by Google-maps, its shows in localtime. When the timezone is not known by Google-maps, it shows in GMT, and displays a small notice at the bottom. At first I thought it was Brave and Tor that weren't sending the timezone for privacy/tracking concerns, but even Chrome support is inconsistent. Working Browsers: Debian 12, Firefox 115.5.0esr (64-bit) Android 13: Chrome 121.0.6167.143 Android 13, Firefox 122.0.1 Fallback to GMT(displayed at the bottom of page): Debian 12, Chome Version 119.0.6045.159 (Official Build) (64-bit) Android 13, Brave 1.62.156 based on Chromium 121.0.6167.139 Android 13, TorBrowser 115.2.1-release(13.0.9) Update dev/source/docs/ardupilot-discord-server.rst
Hwurzburg
force-pushed
the
pr-googlecal-timezone
branch
from
e4a695a
to
db1c2c6
Compare
|
if we know about an issue with a utility or program we recommend, I like to include the caveat....thanks...merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the timezone known by Google-maps, its shows in localtime. When the timezone is not known by Google-maps, it shows in GMT, and displays a small notice at the bottom. At first I thought it was Brave and Tor that weren't sending the timezone for privacy/tracking concerns, but even Chrome support is inconsistent.
Working Browsers:
Debian 12, Firefox 115.5.0esr (64-bit)
Android 13: Chrome 121.0.6167.143
Android 13, Firefox 122.0.1
Fallback to GMT(displayed at the bottom of page):
Debian 12, Chome Version 119.0.6045.159 (Official Build) (64-bit) Android 13, Brave 1.62.156 based on Chromium 121.0.6167.139 Android 13, TorBrowser 115.2.1-release(13.0.9)