Add altitudeOnly attribute #824
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an attribute in order to indicate a command has an altitude in param 7, but not a lat/lon in param 5/6. It also adds comments to note exactly what the other attributes mean (i.e. a lat/lon in param 3, 4 would not "count").
This allows more precise documentation about issues with using a altitude-only command.
This comes out of MAV call discussion summarised here: mavlink/mavlink#1994 (comment) . There was thought of modifying these to be hasLatLon, and hasAltitude, but decided to reduce churn.