Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: eslint@8 support #289

Merged
merged 4 commits into from Oct 22, 2021
Merged

feat!: eslint@8 support #289

merged 4 commits into from Oct 22, 2021

Conversation

AriPerkkio
Copy link
Owner

@AriPerkkio AriPerkkio commented Oct 19, 2021 •
edited

  • BREAKING CHANGE: Reported rules now may include plugin name, e.g. no-unstable-components -> react/no-unstable-components. These are used in reported results and in some callbacks of eslint-remote-tester.config.js.

Closes #288.

@AriPerkkio AriPerkkio changed the title feat: eslint@8 support feat!: eslint@8 support Oct 19, 2021
@AriPerkkio AriPerkkio force-pushed the feat/eslint-8-support branch 3 times, most recently from 3df660e to 2e62d04 Compare October 22, 2021 17:53
@AriPerkkio
chore(dev-deps): eslint@8, eslint-remote-tester-run-action@v2
77ab07e
@AriPerkkio
feat!: improve ruleId parsing
c09dafb 
BREAKING CHANGE: Reported rules now may include plugin name,
e.g. `no-unstable-components` -> `react/no-unstable-components`
These are used in reported results and in some callbacks of eslint-remote-tester.config.js.

- parse `ruleId` from stack traces provided by ESLint v8
@AriPerkkio AriPerkkio marked this pull request as ready for review October 22, 2021 18:16
@AriPerkkio AriPerkkio merged commit 69a14c6 into master Oct 22, 2021
@AriPerkkio AriPerkkio deleted the feat/eslint-8-support branch October 22, 2021 18:18
@AriPerkkio
Copy link
Owner Author

  • eslint-remote-tester@1.3.1 works with eslint@8 without any changes
  • eslint-remote-tester@2.0.0 works with eslint@7 and eslint@8
  • eslint-remote-tester@2.0.0 adds improved ruleId parsing when used with eslint@8
  • eslint-remote-tester-run-action@v1 does not work with eslint@8
  • eslint-remote-tester-run-action@v2 works with eslint@8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint 8 support
1 participant
@AriPerkkio