feat(datasets): multi-select on span / traces tables #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeldking
changed the title
bottom selection toolbar create a span selection toolbar Add datasets query get selection working refactor: use input and output types for create datasets mutation (#3242) WIP final refactor, typecheck
mikeldking
force-pushed
the
3202-spans-multi-select
branch
from
4988f4f
to
4f927f5
Compare
dosubot
bot
added
the
size:XXL
RogerHYang
approved these changes
May 21, 2024
axiomofjoy
approved these changes
May 21, 2024
Comment on lines
+77
to
+84
| onDatasetCreated={(newDataset) => { | ||
| notifySuccess({ | ||
| title: "Dataset created", | ||
| message: `${payload.dataset.name} has been successfully created.`, | ||
| message: `${newDataset.name} has been successfully created.`, | ||
| action: { | ||
| text: "Go to Dataset", | ||
| onClick: () => { | ||
| navigate(`/datasets/${payload.dataset.id}`); | ||
| navigate(`/datasets/${newDataset.id}`); |
Comment on lines
+102
to
+109
| const datasets = useMemo(() => { | ||
| let datasets = data.datasets.edges.map((edge) => edge.dataset); | ||
| if (search) { | ||
| datasets = datasets.filter((dataset) => | ||
| dataset.name.toLowerCase().includes(search.toLowerCase()) | ||
| ); | ||
| } | ||
| return datasets; |
There was a problem hiding this comment.
Assuming this is the part we would like to make a LIKE query for. Do we have a ticket for that yet?
Comment on lines
+86
to
+101
| const [data] = useRefetchableFragment( | ||
| graphql` | ||
| fragment DatasetSelectorPopoverContent_datasets on Query | ||
| @refetchable(queryName: "DatasetSelectorPopoverContentDatasetsQuery") { | ||
| datasets { | ||
| edges { | ||
| dataset: node { | ||
| id | ||
| name | ||
| } | ||
| } | ||
| } | ||
| } | ||
| `, | ||
| props.query | ||
| ); |
There was a problem hiding this comment.
Is this a place where we should add debounce?
| alignItems="center" | ||
| flex="1 1 auto" | ||
| > | ||
| <Text>No datasets found</Text> |
There was a problem hiding this comment.
Could use some padding here.
mikeldking
added a commit
that referenced
this pull request
May 21, 2024
mikeldking
added a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3202
Adds the ability to add spans as examples to a dataset from the tables
