Support for all-uppercase function wrapped in forwardRef/memo (#11) […

…publish]
ArnaudBarre · May 2, 2023 · c0d156b · c0d156b
1 parent 35cfa85
commit c0d156b
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,9 @@
 # Changelog
 
-## Unreleased
+## 0.4.1
 
 - Ignore `export type *` (fixes #12)
+- Support for all-uppercase function wrapped in forwardRef/memo (#11)
 
 ## 0.4.0
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-refresh",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "license": "MIT",
   "scripts": {
     "build": "scripts/bundle.ts",

diff --git a/src/only-export-components.test.ts b/src/only-export-components.test.ts
@@ -41,6 +41,10 @@ const valid = [
     name: "Direct export uppercase function",
     code: "export function CMS() {};",
   },
+  {
+    name: "Uppercase component with forwardRef",
+    code: "export const SVG = forwardRef(() => <svg/>);",
+  },
   {
     name: "Direct export uppercase component",
     code: "export const CMS = () => {};",

diff --git a/src/only-export-components.ts b/src/only-export-components.ts
@@ -115,7 +115,7 @@ export const onlyExportComponents: TSESLint.RuleModule<
             for (const variable of node.declarations) {
               handleExportIdentifier(
                 variable.id,
-                variable.init?.type === "ArrowFunctionExpression",
+                canBeReactFunctionComponent(variable.init),
                 variable.init,
               );
             }
@@ -193,3 +193,14 @@ export const onlyExportComponents: TSESLint.RuleModule<
     };
   },
 };
+
+const canBeReactFunctionComponent = (init: TSESTree.Expression | null) => {
+  if (!init) return false;
+  if (init.type === "ArrowFunctionExpression") return true;
+  if (init.type === "CallExpression") {
+    if (init.callee.type === "Identifier") {
+      return ["memo", "forwardRef"].includes(init.callee.name);
+    }
+  }
+  return false;
+};