fix(*): Work in progress to be compatible with TypeORM 0.3.1+ #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on this PR to be merged, which fixes insert statements not returning generated values. |
|
hi! i'm curious whats the status on this? 👀 I'm looking to switch to typeorm 0.3+ asap, but obviously want to wait for this compatibility pr to go in. I'd also be open to reviewing or helping if you want. |
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@calvin-summer I just released a version 2.4.0 of the driver that is compatible with TypeORM 0.3.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR making this driver compatible with TypeORM 0.3.1+.
Currently the tests are not working when driver is used against newer versions of TypeORM because of the new
savemethod behavior as reported here.