Support new admin-bro ValidationError parameters #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.2.0 of `admin-bro` changed the parameters to `ValidationError` so that there is no generic `message` as the first argument. This was done in [this commit](SoftwareBrothers/adminjs@6b937c3). So, removed the first argument and upgraded the `admin-bro` peer dependency to `>=2.2.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Version 2.2.0 of
admin-brochanged the parameters toValidationErrorso that there is no genericmessageas the first argument. This was done in this commit.So, I removed the first argument and upgraded the
admin-bropeer dependency to>=2.2.0.However, I wasn't able to build the project nor run the tests (even before my changes). Is the TypeScript compilation also broken for you? I can try to fix it but I'm not at all familiar with the project.
Thanks for taking a look!