Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-289 feature: add pr-number optional input #293

Merged
merged 12 commits into from Jul 14, 2022

Conversation

dalevfenton
Copy link
Contributor

@dalevfenton dalevfenton commented Jul 7, 2022

This PR proposes a fix for #289

Changes:

  • adds a prnumber optional input that can be populated so the action can lookup a Pull Request if it is not in the action context
  • if prnumber finds a Pull Request it will use that to lookup and either create or overwrite the report comment as well as checkout the base branch and run coverage difference report.
  • updates tests for new shape of Options and using the pull_request data set there instead of in the context
  • adds section in README to describe usage

How To Test:

  • create an action that uses the push event
  • populate prnumber with gh-find-current-pr action output
  • open a PR, expect to see coverage run and comment created including with coverage diff
  • push another commit, expect to see the comment updated

Copy link
Owner

@ArtiomTr ArtiomTr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dalevfenton 👋,

Thank you for your work! Sorry for the delay. I didn't have enough time to review your PR. Everything looks perfect, but some tiny changes are required.

src/typings/Options.ts Outdated Show resolved Hide resolved
src/typings/Options.ts Outdated Show resolved Hide resolved
@dalevfenton
Copy link
Contributor Author

@ArtiomTr updated PR with your requested changes, added a couple test cases and updated the README

Copy link
Owner

@ArtiomTr ArtiomTr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArtiomTr ArtiomTr merged commit 1c305f8 into ArtiomTr:main Jul 14, 2022
@ArtiomTr
Copy link
Owner

Thank you for your contribution!

@ArtiomTr
Copy link
Owner

@all-contributors please add @dalevfenton for docs, code

@allcontributors
Copy link
Contributor

@ArtiomTr

I've put up a pull request to add @dalevfenton! 🎉

@ArtiomTr
Copy link
Owner

@dalevfenton These changes are published under the v2.0.9 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants