New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-289 feature: add pr-number optional input #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dalevfenton 👋,
Thank you for your work! Sorry for the delay. I didn't have enough time to review your PR. Everything looks perfect, but some tiny changes are required.
@ArtiomTr updated PR with your requested changes, added a couple test cases and updated the README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your contribution! |
@all-contributors please add @dalevfenton for docs, code |
I've put up a pull request to add @dalevfenton! 🎉 |
@dalevfenton These changes are published under the |
This PR proposes a fix for #289
Changes:
prnumber
optional input that can be populated so the action can lookup a Pull Request if it is not in the actioncontext
prnumber
finds a Pull Request it will use that to lookup and either create or overwrite the report comment as well as checkout the base branch and run coverage difference report.Options
and using thepull_request
data set there instead of in thecontext
How To Test:
push
eventprnumber
with gh-find-current-pr action output