Enhance Custom Rules: Introduce translatableExists and translatableUnique for Validating Translatable Attributes #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gummibeer
requested changes
Apr 23, 2024
- Fix PHPDocs, and Code Style
All request changes fixed, and pushed. |
Gummibeer
reviewed
May 1, 2024
.gitignore
Outdated
| @@ -4,3 +4,4 @@ | |||
| /.phpunit.cache | |||
| /build/ | |||
| /coverage.clover | |||
| .history | |||
There was a problem hiding this comment.
This should go into your global gitignore as it's not related to the project but your local environment.
https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/
|
Tests seem to fail for Laravel 9 |
… InvokableRule interface instead of the new one introduced in Laravel 10. Future updates will accommodate the removal of Laravel 9 support.
Apologies, @Gummibeer, I hadn't realized the compatibility issue with Laravel 9. The code has been updated to accommodate Laravel 9, but it will require further refinement once Laravel 9 is no longer supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Incorporating unique and existence validation for translatable attributes can be crucial for many projects. The current Laravel validation doesn't inherently support this functionality, prompting the need for custom solutions.
This pull request introduces two custom validation rules,
translatableExists, andtranslatableUnique, tailored specifically for validating translatable attributes. With these additions, developers gain the ability to ensure data integrity and uniqueness within multilingual datasets effortlessly.Changes:
Added
translatableExistsrule to validate the existence of translatable attributes.Introduced
translatableUniquerule for enforcing uniqueness constraints on translatable fields.Purpose:
This enhancement empowers developers to perform comprehensive validation on translatable attributes, enhancing data validation capabilities within multilingual contexts. By providing these custom rules, we aim to streamline development workflows and promote best practices in data validation.
Benefits:
Facilitates validation of translatable attributes for existence and uniqueness.
Enhances data integrity and consistency within multilingual datasets.
Provides developers with versatile tools for enforcing validation rules tailored to translatable fields.
Usage:
Developers can now utilize the
translatableExistsandtranslatableUniquerules in Laravel validation logic to ensure data integrity and uniqueness across multilingual attributes effortlessly.