Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render footer below table #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mobot11
Copy link

@mobot11 mobot11 commented Mar 26, 2021

This allows for better keyboard navigation when rendering focusable content in the footer. The current location leads to buttons rendered in the table footer being tabbed to before tabbing to the table.

@mobot11
Copy link
Author

mobot11 commented Mar 26, 2021

@nihgwu hopefully this isn't considered a breaking change. Not sure what kind of side effects this may have.

@nihgwu
Copy link
Contributor

nihgwu commented Mar 29, 2021

It does have side effects, you can try to change the dom node of this example https://autodesk.github.io/react-base-table/examples/footer-renderer, the top border of footer(actually it's the bottom border of table body) is overlapped

@mobot11
Copy link
Author

mobot11 commented Mar 29, 2021

This will probably break consumer snapshots as well. Can you consider making this enhancement in the future? It will help with accessibility.

@highspotjeremy
Copy link

If .BaseTable is updated to be display: flex and position: absolute is removed from .BaseTable__table and .BaseTable__footer, it allows them to stack correctly. This should also be compatible with the header if it was similarly changed and would allow it to stack correctly in the DOM as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants