[WIP] Refactor get_job_listings()
to a class
#1916
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Moves majority of
get_job_listings()
into two classes:WP_Job_Manager_Listing_Query_Generator
WP_Job_Manager_Query_Generator
Functionality should be maintained as much as possible. There are a few minor changes.
get_job_listings()
tests seem to pass.Ideally, we'll use
WP_Job_Manager_Listing_Query_Generator
in Resume Manager to benefit from all the shared code that was inget_job_listings()
andget_resumes()
.I was initially thinking this for 1.34.1, but it seems like too big of a change.
To do: