Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor get_job_listings() to a class #1916

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

jom
Copy link
Member

@jom jom commented Oct 21, 2019

Changes proposed in this Pull Request:

  • Moves majority of get_job_listings() into two classes:

    • Base class: WP_Job_Manager_Listing_Query_Generator
    • WPJM class: WP_Job_Manager_Query_Generator
  • Functionality should be maintained as much as possible. There are a few minor changes. get_job_listings() tests seem to pass.

  • Ideally, we'll use WP_Job_Manager_Listing_Query_Generator in Resume Manager to benefit from all the shared code that was in get_job_listings() and get_resumes().

  • I was initially thinking this for 1.34.1, but it seems like too big of a change.

  • To do:

@jom jom added this to the 1.35.0 milestone Oct 21, 2019
@jom jom self-assigned this Oct 21, 2019
@jom jom force-pushed the refactor/post-query branch 2 times, most recently from 9428fd8 to a459f3e Compare October 21, 2019 17:08
@jom jom modified the milestones: 1.35.0, 1.36.0 Jan 12, 2021
@tripflex
Copy link
Collaborator

Adding myself to this as well just to stay in the loop please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants