Add limitation for wp-prettier v3.0 #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, wp-prettier v3.0 causes the following problem to occur:
This is because of this PR that removed supported for that function entirely in prettier. There have been updates made to
eslint-plugin-prettier
that should resolve it, but there could be additional dependencies that need updating/fixing as well. That might take some time to do in order to support v3.0 of wp-prettier.In the meantime, I have made this small change to the README to ensure someone else doesn't run into this like me.
I'll try and spend some time in fixing this, this week or the next.
Replicating instructions
Follow the readme, including installing the latest wp-prettier version and lint your code. You will run into the same problem as me.