Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: add @wordpress/eslint-plugin/i18n rules to eslint config #15374

Closed
jeherve opened this issue Apr 8, 2020 · 1 comment · Fixed by #16455
Closed

Blocks: add @wordpress/eslint-plugin/i18n rules to eslint config #15374

jeherve opened this issue Apr 8, 2020 · 1 comment · Fixed by #16455
Assignees
@jeherve
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] i18n Internationalization / i18n, adaptation to different languages [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
Dashboard Refactor

Comments

@jeherve
Copy link
Member

jeherve commented Apr 8, 2020

WordPress' @wordpress/eslint-plugin will soon (the changes haven't been released yet) include rules to help with internationalization in blocks.

WordPress/gutenberg#20555

Once that's released, I think we should update extensions/.eslintrc.js to use the plugin:@wordpress/eslint-plugin/i18n configuration.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] i18n Internationalization / i18n, adaptation to different languages [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Apr 8, 2020
@jeherve jeherve self-assigned this Apr 8, 2020
@jeherve jeherve mentioned this issue Jul 10, 2020
Merged
@jeherve jeherve added this to To do in Dashboard Refactor Jul 16, 2020
@jeherve jeherve moved this from To do to In progress in Dashboard Refactor Jul 16, 2020
@jeherve jeherve mentioned this issue Sep 7, 2020
Closed
@jeherve
Copy link
Member Author

jeherve commented Nov 4, 2020

Related: #11822

Dashboard Refactor automation moved this from In progress to Done Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] i18n Internationalization / i18n, adaptation to different languages [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
No open projects
Dashboard Refactor
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Internationalization: introduce new linting plugin for i18n errors in blocks Automattic/jetpack
2 participants
@kraftbj @jeherve