-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/tracks events for my jetpack product card action button dropdown #37292
Add/tracks events for my jetpack product card action button dropdown #37292
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
30281ed
to
fd525e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks mostly fine, but I couldn't get the events to be recorded.
I also left a minor comment about the naming convention we use for Tracks events
@@ -202,9 +205,17 @@ const ActionButton = ( { | |||
[ additionalActions, getStatusAction, hasAdditionalActions ] | |||
); | |||
|
|||
const recordDropdownStateChange = useCallback( () => { | |||
recordEvent( 'jetpack_myjetpack_product_card_dropdown_toggled', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, we tend to use the verb at the end in infinitive form. See more about that here
@@ -235,6 +250,11 @@ const ActionButton = ( { | |||
const onDropdownMenuItemClick = () => { | |||
setCurrentAction( allActions[ index ] ); | |||
setIsDropdownOpen( false ); | |||
|
|||
recordEvent( 'jetpack_myjetpack_product_card_dropdown_action_clicked', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
recordEvent( 'jetpack_myjetpack_product_card_dropdown_action_clicked', { | |
recordEvent( 'jetpack_myjetpack_product_card_dropdown_action_click', { |
@@ -202,9 +205,17 @@ const ActionButton = ( { | |||
[ additionalActions, getStatusAction, hasAdditionalActions ] | |||
); | |||
|
|||
const recordDropdownStateChange = useCallback( () => { | |||
recordEvent( 'jetpack_myjetpack_product_card_dropdown_toggled', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recordEvent( 'jetpack_myjetpack_product_card_dropdown_toggled', { | |
recordEvent( 'jetpack_myjetpack_product_card_dropdown_toggle', { |
b6bf1bc
to
893ce22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tests well.
Proposed changes:
Other information:
Jetpack product discussion
Slack: p1714642553738749-slack-C06CVN9QVFY
Does this pull request change what data or activity we track or use?
Yes, we are adding tracks for the dropdown button for backups
Testing instructions:
/wp-admin/admin.php?page=my-jetpack
and confirm you can see the dropdown (Screenshot doesn't have activity log item because I was forcing it visible in testing)