upgrade mongodb to v3.6.7 #10265
Closed
upgrade mongodb to v3.6.7 #10265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
May 19, 2021
| @@ -910,7 +910,7 @@ function _setClient(conn, client, options, dbName) { | |||
| }); | |||
| client.on('serverDescriptionChanged', ev => { | |||
| const newDescription = ev.newDescription; | |||
| if (newDescription.type === 'Standalone') { | |||
| if (newDescription.type === 'Standalone' || newDescription.type === 'Unknown') { | |||
There was a problem hiding this comment.
This is not likely to be the correct fix here, because if the topology description is "Unknown" we shouldn't consider that as "reconnected." Is this to try to work around the 'timeout' issue in the first commit's test failures?
There was a problem hiding this comment.
Yes, frankly I am not familiar enough with the connection details, I've been trying to make the tests pass but without luck.
You'd probably be much more efficient at fixing this than me.
There was a problem hiding this comment.
@AbdelrahmanHafez I think I identified the issue and opened up a PR in the MongoDB driver. We'll see what they say, I'm not sure whether this was an intentional change or not.
vkarpov15
reviewed
May 21, 2021
vkarpov15
added a commit
that referenced
this pull request
May 21, 2021
1 task
This was referenced Jul 14, 2021
This was referenced Oct 20, 2021
1 task
1 task
1 task
1 task
This was referenced Jan 21, 2022
1 task
This was referenced Feb 3, 2022
1 task
1 task
This was referenced Feb 21, 2022
1 task
This was referenced Mar 10, 2022
1 task
This was referenced Apr 14, 2022
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.