Fix minimize #10952
Closed
Fix minimize #10952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing linter test is weird because that line that it is referencing has no code on it. |
vkarpov15
reviewed
Nov 3, 2021
| if (options._calledWithOptions.minimize != null) { | ||
| _minimize = options.minimize; | ||
| } else if (defaultOptions.minimize != null) { | ||
| _minimize = defaultOptions.minimize; | ||
| } else if (options._parentOptions != null && options.getters != null) { |
There was a problem hiding this comment.
Why options.getters != null here?
There was a problem hiding this comment.
it won't work without it. gh-9405 has tests already and this was the only combination that could get them all to pass.
|
I took a closer look and this is expected behavior. We made the change in #9405 that subdocs inherit parents' minimize and added tests that enforce that behavior, so no way to make this work. The If you find yourself struggling to reconcile behavior that's asserted on in the tests with new behavior, feel free to ask me to clarify in Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.