New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for validateSync
to test ignore async functions but still run error hooks
#12372
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont know what the convention for this is here, though currently in #12371 this PR here (#12372) focuses on hooks, which do not seem to be executed in |
Interesting, I didn't know that. So async validators would run with |
(already answered in #12371 (comment) with similar question) from what i know, in both |
Thanks @hasezoey |
ffdc81f
to
fc0ccc1
Compare
rebased on latest master to resolve conflicts |
@hasezoey is this PR still valid? It's still in draft state and has been for a while, so I wanted to check if we can close this PR. |
i have been waiting for feedback about the pr and the referenced issue, simply said this PR adds a test for a issue, but the functionality is not quite what this test is meant to test and there has not been feedback about what to do (is this wanted behavior or should be changed) if i remember correctly, the current issue is about that i am not sure what the exact problem is / was because the logs have expired and i am currently not on my dev machine |
Ok, I'll take a closer look tomorrow |
…tions and promises
fc0ccc1
to
7f225e8
Compare
rebased onto latest master to resolve conflicts current issue is that both tests fail because none of the 3 |
Summary
This PR adds tests that test
validateSync
to execute sync functions and error hooks but ignoreasync function()
and ignores returned Promisesfixes #8703
Blocked currently because
validateSync
does not seem to execute any hooks